Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Feature/gen 297 #63

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Feature/gen 297 #63

merged 3 commits into from
Jan 26, 2024

Conversation

dave-at-koor
Copy link
Member

All about sales

Copy link

linear bot commented Jan 25, 2024

Copy link

cloudflare-workers-and-pages bot commented Jan 25, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0532948
Status: ✅  Deploy successful!
Preview URL: https://a9789335.handbook-v2.pages.dev
Branch Preview URL: https://feature-gen-297.handbook-v2.pages.dev

View logs

docs/sales/index.md Outdated Show resolved Hide resolved
Copy link

@aaron-at-koor aaron-at-koor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one wording error. Left comment for correction. And have since decided it was not needed. Looks good to me.

docs/sales/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zalsader zalsader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ambitious but we can do it 💪

@IanEff
Copy link

IanEff commented Jan 26, 2024

Looks good on first read! I think there're a few typos, though. For example:
"The Data Control Center is a materialization of the data control plane, which more of an abstract notion." The wording is amazing-- it concisely conveys our passion and excitement about the tech we work with-- but it needs an "is..!"
I'll take another pass at it once the network's back up!

@dave-at-koor
Copy link
Member Author

Looks good on first read! I think there're a few typos, though. For example: "The Data Control Center is a materialization of the data control plane, which more of an abstract notion." The wording is amazing-- it concisely conveys our passion and excitement about the tech we work with-- but it needs an "is..!" I'll take another pass at it once the network's back up!

I am not sure what you are referencing (but I can search). To make it easier, you can start a review and make the suggestion inline to show where it belongs. Then submit the review with one of the options. That will also give you the credit for reviewing.

@dave-at-koor
Copy link
Member Author

Looks good on first read! I think there're a few typos, though. For example: "The Data Control Center is a materialization of the data control plane, which more of an abstract notion." The wording is amazing-- it concisely conveys our passion and excitement about the tech we work with-- but it needs an "is..!" I'll take another pass at it once the network's back up!

I am not sure what you are referencing (but I can search). To make it easier, you can start a review and make the suggestion inline to show where it belongs. Then submit the review with one of the options. That will also give you the credit for reviewing.

Ah, you were reading the product roadmap, which wasn't changed for this PR. So useful but unrelated.

@dave-at-koor dave-at-koor merged commit bcd4c77 into main Jan 26, 2024
2 checks passed
@dave-at-koor dave-at-koor deleted the feature/gen-297 branch January 26, 2024 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants